Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19381#discussion_r181015190
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
    @@ -192,12 +192,12 @@ abstract class ClassificationModel[FeaturesType, M <: 
ClassificationModel[Featur
     
       /**
        * Predict label for the given features.
    -   * This internal method is used to implement `transform()` and output 
[[predictionCol]].
    +   * This method is used to implement `transform()` and output 
[[predictionCol]].
        *
        * This default implementation for classification predicts the index of 
the maximum value
        * from `predictRaw()`.
        */
    -  override protected def predict(features: FeaturesType): Double = {
    +  override def predict(features: FeaturesType): Double = {
    --- End diff --
    
    I think no. It will inherit `@Since` from super class `predict` method.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to