Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21078#discussion_r182833420 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -150,3 +156,35 @@ private[spark] object Instrumentation { } } + +private[spark] class OptionalInstrument private ( + val instrument: Option[Instrumentation[_ <: Estimator[_]]], --- End diff -- instrument -> either `instrumentation` or `instr`
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org