Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/21078#discussion_r182836091
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -378,18 +378,24 @@ class LinearRegression @Since("1.3.0")
(@Since("1.3.0") override val uid: String
val yMean = ySummarizer.mean(0)
val rawYStd = math.sqrt(ySummarizer.variance(0))
+
+ instr.logNamedValue(Instrumentation.loggerTags.numExamples,
ySummarizer.count)
--- End diff --
It might be worth creating a logNumExamples() method in Instrumentation
since I bet we'll add this elsewhere.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
