Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2685#issuecomment-60787703
@marmbrus, there are some problems when consolidating all the Shim code
into the existing hive subproject. The shim code of thriftserver depend on some
classes of hive-thriftserver such as ```SparkSQLCLIService```,
```AbstractSparkSQLDriver```. So moving them to hive subproject leads to hive
dependency on hive-thriftserver, that is not we expected.
And another problem is that if we consolidate all shim code in a
existing(or new) subproject, we need include hive-thriftserver in parent pom to
ensure compile ok. This violates that now we do not include/compile
hive-thriftserver default.
So i suggest keep the shim code for themselves, and hive-thriftserver can
reuse some shim code of hive to avoid duplicating code:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
