Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21092#discussion_r183153556
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -695,9 +693,17 @@ private[spark] class SparkSubmit extends Logging {
         if (isKubernetesCluster) {
           childMainClass = KUBERNETES_CLUSTER_SUBMIT_CLASS
           if (args.primaryResource != SparkLauncher.NO_RESOURCE) {
    -        childArgs ++= Array("--primary-java-resource", 
args.primaryResource)
    +        if (args.isPython) {
    --- End diff --
    
    This logic appears to duplicated from YARN, would it make sense to factor 
this out into a common function?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to