Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21092#discussion_r183156236
  
    --- Diff: 
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
 ---
    @@ -55,7 +55,8 @@ class KubernetesConfSuite extends SparkFunSuite {
           APP_ID,
           None,
           MAIN_CLASS,
    -      APP_ARGS)
    +      APP_ARGS,
    +      None)
    --- End diff --
    
    Commonly, to improve readability, we assign names to the the None params 
(e.g. foobaz=None) rather than positional arguments.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to