Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r184210860
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -126,7 +126,7 @@ private[scheduler] class BlacklistTracker (
nodeIdToBlacklistExpiryTime.remove(node)
listenerBus.post(SparkListenerNodeUnblacklisted(now, node))
}
- _nodeBlacklist.set(nodeIdToBlacklistExpiryTime.keySet.toSet)
+
_nodeBlacklist.set(collection.immutable.Map(nodeIdToBlacklistExpiryTime.toSeq:
_*))
--- End diff --
Isn't this the same as calling `nodeIdToBlacklistExpiryTime.toMap`? (That
returns an immutable map.)
At the very least, the `collectiom.immutable.` part looks unnecessary. Same
thing happens below.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
