Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21068#discussion_r184216378
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
 ---
    @@ -204,35 +185,23 @@ private[yarn] class YarnAllocator(
        * @param localityAwareTasks number of locality aware tasks to be used 
as container placement hint
        * @param hostToLocalTaskCount a map of preferred hostname to possible 
task counts to be used as
        *                             container placement hint.
    -   * @param nodeBlacklist a set of blacklisted nodes, which is passed in 
to avoid allocating new
    -    *                      containers on them. It will be used to update 
the application master's
    -    *                      blacklist.
    +   * @param schedulerBlacklistedNodesWithExpiry blacklisted nodes with 
expiry times, which is passed
    --- End diff --
    
    Another name that is a mouthful... the previous name was fine. Or maybe 
`schedulerBlacklist` if you want to emphasize where it is supposed to come from.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to