Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r184575258
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -170,8 +170,7 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
if (executorDataMap.contains(executorId)) {
executorRef.send(RegisterExecutorFailed("Duplicate executor ID:
" + executorId))
context.reply(true)
- } else if (scheduler.nodeBlacklist != null &&
- scheduler.nodeBlacklist.contains(hostname)) {
+ } else if
(scheduler.nodeBlacklistWithExpiryTimes.contains(hostname)) {
--- End diff --
this change seems to be causing all the test failures. Its because there
are tests that use a mock TaskSchedulerImpl, and so
`scheduler.nodeBlacklistWithExpiryTimes` returns null from the mock.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
