Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r184211525
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -651,8 +651,8 @@ private[spark] class TaskSchedulerImpl(
* Get a snapshot of the currently blacklisted nodes for the entire
application. This is
* thread-safe -- it can be called without a lock on the TaskScheduler.
*/
- def nodeBlacklist(): scala.collection.immutable.Set[String] = {
-
blacklistTrackerOpt.map(_.nodeBlacklist()).getOrElse(scala.collection.immutable.Set())
+ def nodeBlacklistWithExpiryTimes():
scala.collection.immutable.Map[String, Long] = {
--- End diff --
Why not just `Map[String, Long]`?
I kinda find it odd when I see these types used this way, so unless there's
a good reason...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
