Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21165#discussion_r185688449
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -212,9 +212,15 @@ case object TaskResultLost extends TaskFailedReason {
* Task was killed intentionally and needs to be rescheduled.
*/
@DeveloperApi
-case class TaskKilled(reason: String) extends TaskFailedReason {
+case class TaskKilled(
+ reason: String,
+ accumUpdates: Seq[AccumulableInfo] = Seq.empty,
+ private[spark] val accums: Seq[AccumulatorV2[_, _]] = Nil)
--- End diff --
now the question is: shall we keep the unnecessary Seq[AccumulableInfo] in
new APIs, to make the API consistent? I'd like to not keep the
Seq[AccumulableInfo], we may deprecate it in the existing APIs in the near
future.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
