Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/21165#discussion_r185690094
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -212,9 +212,15 @@ case object TaskResultLost extends TaskFailedReason {
* Task was killed intentionally and needs to be rescheduled.
*/
@DeveloperApi
-case class TaskKilled(reason: String) extends TaskFailedReason {
+case class TaskKilled(
+ reason: String,
+ accumUpdates: Seq[AccumulableInfo] = Seq.empty,
+ private[spark] val accums: Seq[AccumulatorV2[_, _]] = Nil)
--- End diff --
I'm ok with not keeping `Seq[AccumulableInfo]`. But it means inconsistent
logic and api and may make future refactoring a bit difficult.
Let's see what I can do.
> I'd like to not keep the Seq[AccumulableInfo], we may deprecate it in
the existing APIs in the near future.
BTW, I think we have already deprecated `AccumulableInfo`. Unless we are
planing to remove it in Spark 3.0 and Spark 3.0 is the next release,
`AccumulableInfo` will be there for a long time
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
