Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2840#discussion_r19516413
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala
 ---
    @@ -66,7 +66,16 @@ private[spark] object CoarseGrainedClusterMessages {
     
       case class RemoveExecutor(executorId: String, reason: String) extends 
CoarseGrainedClusterMessage
     
    -  case class AddWebUIFilter(filterName:String, filterParams: Map[String, 
String], proxyBase :String)
    +  case class AddWebUIFilter(filterName:String, filterParams: Map[String, 
String], proxyBase: String)
         extends CoarseGrainedClusterMessage
     
    +  // Messages exchanged between the driver and the cluster manager for 
executor allocation
    --- End diff --
    
    "cluster manager" is a little confusing here, because historically it's 
meant the external services like YARN, Mesos, Standalone.  Maybe "cluster 
manager adapter" or something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to