Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/2840#issuecomment-60863771
Had a look over the patch and my main comments were just on doc. In
particular we should be careful to be precise about what we mean by "cluster
manager". The other concern I had was that, in allocateResources, can
`missing` end up negative? This seems like it could cause some weird behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
