Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21255#discussion_r186633965
--- Diff: R/pkg/R/functions.R ---
@@ -1253,19 +1256,6 @@ setMethod("quarter",
column(jc)
})
-#' @details
-#' \code{reverse}: Reverses the string column and returns it as a new
string column.
-#'
-#' @rdname column_string_functions
-#' @aliases reverse reverse,Column-method
-#' @note reverse since 1.5.0
-setMethod("reverse",
- signature(x = "Column"),
- function(x) {
- jc <- callJStatic("org.apache.spark.sql.functions", "reverse",
x@jc)
- column(jc)
- })
-
--- End diff --
right, but that's not strictly where collection functions are.
I'm not saying we need to re-sort/group all functions - that will be
thousands of lines we need to change
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
