Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21255#discussion_r186634471
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2043,34 +2033,6 @@ setMethod("countDistinct",
                 column(jc)
               })
     
    -#' @details
    -#' \code{concat}: Concatenates multiple input columns together into a 
single column.
    -#' If all inputs are binary, concat returns an output as binary. 
Otherwise, it returns as string.
    -#'
    -#' @rdname column_string_functions
    -#' @aliases concat concat,Column-method
    -#' @examples
    -#'
    -#' \dontrun{
    -#' # concatenate strings
    -#' tmp <- mutate(df, s1 = concat(df$Class, df$Sex),
    -#'                   s2 = concat(df$Class, df$Sex, df$Age),
    -#'                   s3 = concat(df$Class, df$Sex, df$Age, df$Class),
    -#'                   s4 = concat_ws("_", df$Class, df$Sex),
    -#'                   s5 = concat_ws("+", df$Class, df$Sex, df$Age, 
df$Survived))
    --- End diff --
    
    yes, let's not lose example.
    we should add concat to the column_collection_functions
    and concat_ws to column_string_functions


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to