Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21255
Yes
________________________________
From: Hyukjin Kwon <notificati...@github.com>
Sent: Thursday, May 10, 2018 9:16:28 AM
To: apache/spark
Cc: Felix Cheung; Mention
Subject: Re: [apache/spark] [SPARK-24186][R][SQL]change reverse and concat
to collection functions in R (#21255)
@HyukjinKwon commented on this pull request.
________________________________
In
R/pkg/tests/fulltests/test_sparkSQL.R<https://github.com/apache/spark/pull/21255#discussion_r187380148>:
> @@ -1502,12 +1502,25 @@ test_that("column functions", {
result <- collect(select(df, sort_array(df[[1]])))[[1]]
expect_equal(result, list(list(1L, 2L, 3L), list(4L, 5L, 6L)))
- # Test flattern
+ result <- collect(select(df, reverse(df[[1]])))[[1]]
+ expect_equal(result, list(list(3L, 2L, 1L), list(4L, 5L, 6L)))
+
+ df2 <- createDataFrame(list(list("abc")))
+ result <- collect(select(df2, reverse(df2[[1]])))[[1]]
+ expect_equal(result, "cba")
+
+ # Test flattern()
flattern -> flatten.
â
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub<https://github.com/apache/spark/pull/21255#pullrequestreview-119149584>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/AIjc-9PLjYLZAi6YHkE9OSrg0zVnOHrjks5txGfcgaJpZM4T0f1k>.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
