Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/21165#discussion_r187984186
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -287,6 +287,28 @@ private[spark] class Executor(
notifyAll()
}
+ /**
+ * Utility function to:
+ * 1. Report executor runtime and JVM gc time if possible
+ * 2. Collect accumulator updates
+ * 3. Set the finished flag to true and clear current thread's
interrupt status
+ */
+ private def collectAccumulatorsAndResetStatusOnFailure(taskStart:
Long) = {
+ // Report executor runtime and JVM gc time
+ Option(task).foreach(t => {
+ t.metrics.setExecutorRunTime(System.currentTimeMillis() -
taskStart)
--- End diff --
e, `startStart` is already defined previously. Do you think we need to
replace all the `taskStart` to `taskStartTime`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
