Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2994#discussion_r19579681
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ProducerCache.scala
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.streaming.kafka
+
+object ProducerCache {
+
+ private var producerOpt: Option[Any] = None
--- End diff --
My understanding is that the tasks are all part of the same application -
so it should be fine (we are not sharing data between applications).
The Producer is thread-safe (I tested that while writing a KafkaChannel for
Flume), so that should be fine.
But if it is not that heavy to create per partition (it would be around
once per 2 seconds or so), then I will go ahead and do that. That does have the
benefit of avoiding some of the complex code meant to handle reusing the
producer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
