Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21324#discussion_r188078585
  
    --- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -398,7 +398,7 @@ hintStatement
         ;
     
     fromClause
    -    : FROM relation (',' relation)* (pivotClause | lateralView*)?
    +    : FROM relation (',' relation)* lateralView* pivotClause?
    --- End diff --
    
    as I said in the e-mail in the dev list, I think that the right fix is 
`(pivotClause | lateralView+)?`. I have been running the tests and they are 
successful so far, so I think this is the right approach. It also avoids the 
additional check needed to throw the ParseException.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to