Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21324#discussion_r188177303
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -398,7 +398,7 @@ hintStatement
;
fromClause
- : FROM relation (',' relation)* (pivotClause | lateralView*)?
+ : FROM relation (',' relation)* lateralView* pivotClause?
--- End diff --
@mgaido91 Better readability is more important to our end users. Currently,
we rely on ANTLR4 to issue the error message in most cases. However, ANTLR4 is
not good to issue a readable error message, compared with the commercial
vendor.
We need to revisit what our current Parser implementation and improve the
error handling.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
