Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189202465
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -100,17 +101,18 @@ abstract class Expression extends
TreeNode[Expression] {
ctx.subExprEliminationExprs.get(this).map { subExprState =>
// This expression is repeated which means that the code to evaluate
it has already been added
// as a function before. In that case, we just re-use it.
- ExprCode(ctx.registerComment(this.toString), subExprState.isNull,
subExprState.value)
+ ExprCode(ctx.registerComment(this.toString), subExprState.isNull,
+ subExprState.value)
--- End diff --
unnecessary change
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
