Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21193#discussion_r188907963
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
 ---
    @@ -114,6 +114,113 @@ object JavaCode {
       }
     }
     
    +/**
    + * A trait representing a block of java code.
    + */
    +trait Block extends JavaCode {
    +
    +  // The expressions to be evaluated inside this block.
    +  def exprValues: Seq[ExprValue]
    --- End diff --
    
    isn't it enough to compare `exprValues` with a `Set` containing the 
expected  elements instead of comparing them one by one?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to