Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21390#discussion_r189809055
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -226,6 +246,29 @@ private void deleteExecutorDirs(String[] dirs) {
}
}
+ private FilenameFilter filter = new FilenameFilter() {
--- End diff --
Is it feasible to define this as a locale variable inside of
`deleteNonShuffleFiles` in order to reduce its scope to be as small as possible
and make it clear that this is only used within `deleteNonShuffleFiles`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
