Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21390#discussion_r189809797
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -97,6 +97,10 @@ private[deploy] class Worker(
private val APP_DATA_RETENTION_SECONDS =
conf.getLong("spark.worker.cleanup.appDataTtl", 7 * 24 * 3600)
+ // Whether or not cleanup the non-shuffle files on executor finishes.
+ private val CLEANUP_NON_SHUFFLE_FILES_ENABLED =
+ conf.getBoolean("spark.worker.cleanup.nonShuffleFiles.enabled", true)
--- End diff --
Should we document this configuration at
https://github.com/apache/spark/blob/master/docs/spark-standalone.md ?
I can't imagine a great reason for users wanting to disable this and
believe that this is functioning primarily as a feature-flag to give us an
escape-hatch in case of regressions, so maybe it's not a huge deal to leave it
undocumented?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
