Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21313#discussion_r192577008
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3006,6 +3008,27 @@ setMethod("array_contains",
                 column(jc)
               })
     
    +#' @details
    +#' \code{array_join}: Concatenates the elements of column using the 
delimiter.
    +#' Null values are replaced with nullReplacement if set, otherwise they 
are ignored.
    +#'
    +#' @param delimiter character(s) to use to concatenate the elements of 
column.
    +#' @param nullReplacement character(s) to use to replace the Null values.
    +#' @rdname column_collection_functions
    +#' @aliases array_join array_join,Column-method
    +#' @note array_join since 2.4.0
    +setMethod("array_join",
    +         signature(x = "Column"),
    --- End diff --
    
    is `delimiter` supposed to be a string? it's better to have its type in the 
signature


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to