Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21313#discussion_r192925340
--- Diff: R/pkg/R/functions.R ---
@@ -3006,6 +3008,27 @@ setMethod("array_contains",
column(jc)
})
+#' @details
+#' \code{array_join}: Concatenates the elements of column using the
delimiter.
+#' Null values are replaced with nullReplacement if set, otherwise they
are ignored.
+#'
+#' @param delimiter a character string that is used to concatenate the
elements of column.
+#' @param nullReplacement a character string that is used to replace the
Null values.
--- End diff --
could you change this to
`nullReplacement an optional character string `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
