Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r193320743
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala
---
@@ -34,7 +34,12 @@ object PythonUDF {
e.isInstanceOf[PythonUDF] &&
SCALAR_TYPES.contains(e.asInstanceOf[PythonUDF].evalType)
}
- def isGroupAggPandasUDF(e: Expression): Boolean = {
+ def isGroupedAggPandasUDF(e: Expression): Boolean = {
+ e.isInstanceOf[PythonUDF] &&
+ e.asInstanceOf[PythonUDF].evalType ==
PythonEvalType.SQL_GROUPED_AGG_PANDAS_UDF
+ }
+
+ def isWindowPandasUDF(e: Expression): Boolean = {
--- End diff --
@icexelloss, can we maybe do:
```
def isWindowPandasUDF(e: Expression): = isGroupedAggPandasUDF(e)
```
and explain why they can be same ..
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
