Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r193323414
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -424,6 +424,21 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
}
}
+ object Window extends Strategy {
+ def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
+ case PhysicalWindow(
+ WindowFunctionType.SQL, windowExprs, partitionSpec, orderSpec,
child) =>
+ execution.window.WindowExec(
+ windowExprs, partitionSpec, orderSpec, planLater(child)) :: Nil
+
+ case PhysicalWindow(
+ WindowFunctionType.Python, windowExprs, partitionSpec, orderSpec,
child) =>
+ execution.python.WindowInPandasExec(
+ windowExprs, partitionSpec, orderSpec, planLater(child)) :: Nil
--- End diff --
tiny nit: I would add a newline below
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
