Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21575#discussion_r196428732
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -75,16 +76,18 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext, clock: Clock)
// "spark.network.timeout" uses "seconds", while
`spark.storage.blockManagerSlaveTimeoutMs` uses
// "milliseconds"
private val slaveTimeoutMs =
- sc.conf.getTimeAsMs("spark.storage.blockManagerSlaveTimeoutMs", "120s")
+ sc.conf.getTimeAsMs("spark.storage.blockManagerSlaveTimeoutMs",
--- End diff --
The val `slaveTimeoutMs` is only used in
https://github.com/apache/spark/blob/c6ff59a230758b409fa9cc548b7d283eeb7ebe5d/core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala#L80,
so I don't think this change shall fix anything.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
