Github user xueyumusic commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21575#discussion_r197028516
  
    --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
    @@ -75,16 +76,18 @@ private[spark] class HeartbeatReceiver(sc: 
SparkContext, clock: Clock)
       // "spark.network.timeout" uses "seconds", while 
`spark.storage.blockManagerSlaveTimeoutMs` uses
       // "milliseconds"
       private val slaveTimeoutMs =
    -    sc.conf.getTimeAsMs("spark.storage.blockManagerSlaveTimeoutMs", "120s")
    +    sc.conf.getTimeAsMs("spark.storage.blockManagerSlaveTimeoutMs",
    --- End diff --
    
    I have removed temp val `slaveTimeout`, also `timeoutIntervalMs` is the 
same case, so removed too, thanks @zsxwing @jiangxb1987 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to