Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21575#discussion_r198576712
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
    @@ -371,6 +371,23 @@ class SparkConfSuite extends SparkFunSuite with 
LocalSparkContext with ResetSyst
           assert(thrown.getMessage.contains(key))
         }
       }
    +
    +  test("SPARK-24566") {
    --- End diff --
    
    This test is useless. It tests copy-pasted codes and if someone changes the 
original codes, this will still pass. I prefer to not add this one.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to