Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21621#discussion_r197611537
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -199,7 +199,7 @@ case class ArraysZip(children: Seq[Expression]) extends
Expression with ExpectsI
""".stripMargin
}
- val splittedGetValuesAndCardinalities = ctx.splitExpressions(
+ val splittedGetValuesAndCardinalities =
ctx.splitExpressionsWithCurrentInputs(
--- End diff --
LGTM.
Direct call of `splitExpressions` here has two problems:
1. `splitExpressions` can't work under wholestage codegen.
2. current row input is ignored in `arguments` for non wholestage codegen.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
