Github user bersprockets commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21621#discussion_r197646450
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -556,6 +556,17 @@ class DataFrameFunctionsSuite extends QueryTest with 
SharedSQLContext {
         checkAnswer(df8.selectExpr("arrays_zip(v1, v2)"), expectedValue8)
       }
     
    +  test("SPARK-24633: arrays_zip splits input processing correctly") {
    +    Seq("true", "false").foreach { wholestageCodegenEnabled =>
    +      withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> 
wholestageCodegenEnabled) {
    +        val df = spark.range(1)
    +        val exprs = (0 to 5).map(x => array($"id" + lit(x)))
    --- End diff --
    
    @mgaido91 Got it, you were testing that it does not split when 
wholestagecodegen is enabled.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to