Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r198338923
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
@@ -369,7 +369,7 @@ private[spark] class ExternalSorter[K, V, C](
type Iter = BufferedIterator[Product2[K, C]]
val heap = new mutable.PriorityQueue[Iter]()(new Ordering[Iter] {
// Use the reverse of comparator.compare because PriorityQueue
dequeues the max
- override def compare(x: Iter, y: Iter): Int =
-comparator.compare(x.head._1, y.head._1)
--- End diff --
Remove the comment as we don't use the reverse of `comparator.compare` now?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
