Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r198339898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -294,7 +294,8 @@ object CaseWhen {
case cond :: value :: Nil => Some((cond, value))
case value :: Nil => None
}.toArray.toSeq // force materialization to make the seq serializable
- val elseValue = if (branches.size % 2 == 1) Some(branches.last) else
None
+ // avoid false positive of IM_BAD_CHECK_FOR_ODD by SpotBugs
--- End diff --
I feel that this comment might be a bit confusing to readers. Is it good
without this comment?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
