Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199384289
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,35 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXPYTHON
+SPHINXBUILD ?= sphinx-build
+# User-friendly check for sphinx-build if explicitly specified.
+ifeq ($(shell which $(SPHINXBUILD) >/dev/null 2>&1; echo $$?), 1)
+$(error The '$(SPHINXBUILD)' command was not found. Make sure you have
Sphinx installed, then set the SPHINXBUILD environment variable to point to the
full path of the '$(SPHINXBUILD)' executable. Alternatively you can add the
directory with the executable to your PATH. If you don't have Sphinx installed,
grab it from http://sphinx-doc.org/)
+endif
--- End diff --
That seems error prone - why not pick a good default of python3 and allow
overriding?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
