Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21712#discussion_r200053026
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala 
---
    @@ -122,6 +122,22 @@ class HiveClientSuite(version: String)
           "aa" :: Nil)
       }
     
    +  test("getPartitionsByFilter: cast(chunk as int)=1 (not a valid partition 
predicate)") {
    +    testMetastorePartitionFiltering(
    +      attr("chunk").cast(IntegerType) === 1,
    +      20170101 to 20170103,
    +      0 to 23,
    +      "aa" :: "ab" :: "ba" :: "bb" :: Nil)
    +  }
    +
    +  test("getPartitionsByFilter: cast(chunk as boolean)=1 (not a valid 
partition predicate)") {
    --- End diff --
    
    nit: cast(chunk as boolean)=true


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to