Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21712#discussion_r200105115
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
---
@@ -122,6 +122,22 @@ class HiveClientSuite(version: String)
"aa" :: Nil)
}
+ test("getPartitionsByFilter: cast(chunk as int)=1 (not a valid partition
predicate)") {
--- End diff --
yes this can pass, we can tell it by #12586
`Cast.mayTruncate` returns true for string to int, but not string to
boolean. Here I just wanna test both of the cases, to improve test coverage.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
