Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19720295
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -124,9 +124,9 @@ object ScalaReflection {
case obj: LongType.JvmType => LongType
case obj: FloatType.JvmType => FloatType
case obj: DoubleType.JvmType => DoubleType
- case obj: DateType.JvmType => DateType
case obj: BigDecimal => DecimalType.Unlimited
case obj: Decimal => DecimalType.Unlimited
+ case obj: DateType.JvmType => DateType
--- End diff --
I guess you moved this line here because `DateType` and `TimestampType` are
more tightly related. This is consideration is legitimate and I'd also choose
this order if I were the original author. However, this change introduces
larger probability of future merge conflicts, while the benefit is rather
limited. Same principle applies to all other similar reordering changes related
to `Date` and `Timestamp` in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
