Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61447235
Hey @culler, in general I like the DSL improvements, thanks for the work!
Left some in-line comments, and two additional hight level comments here:
1. Usually we encourage one PR for one code change. It's harder to track
and review if developers mix several unrelated or loosely related changes into
a single PR.
2. Please always add sufficient tests for changes made in the PR unless
they are trivial (e.g. renaming or styling changes).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
