Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200514990
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -31,19 +31,18 @@ import scala.collection.JavaConverters._
import org.apache.spark.SparkFunSuite
import
org.apache.spark.deploy.k8s.integrationtest.backend.{IntegrationTestBackend,
IntegrationTestBackendFactory}
import org.apache.spark.deploy.k8s.integrationtest.config._
-import org.apache.spark.launcher.SparkLauncher
private[spark] class KubernetesSuite extends SparkFunSuite
- with BeforeAndAfterAll with BeforeAndAfter {
+ with BeforeAndAfterAll with BeforeAndAfter with BasicTestsSuite with
SecretsTestsSuite {
import KubernetesSuite._
private var testBackend: IntegrationTestBackend = _
private var sparkHomeDir: Path = _
- private var kubernetesTestComponents: KubernetesTestComponents = _
- private var sparkAppConf: SparkAppConf = _
+ protected var kubernetesTestComponents: KubernetesTestComponents = _
--- End diff --
Do you really need protected vs `private[k8s]` or something? I don't know
enough to have much of an opinion though. The `protected` just looked a little
unusual for member variables.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
