Github user culler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3066#discussion_r19734582
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala 
---
    @@ -124,9 +124,9 @@ object ScalaReflection {
         case obj: LongType.JvmType => LongType
         case obj: FloatType.JvmType => FloatType
         case obj: DoubleType.JvmType => DoubleType
    -    case obj: DateType.JvmType => DateType
         case obj: BigDecimal => DecimalType.Unlimited
         case obj: Decimal => DecimalType.Unlimited
    +    case obj: DateType.JvmType => DateType
    --- End diff --
    
    Yes.  Well, the truth is that I was originally working with the source for 
Spark 1.1.0.  When I pulled the current code it turned out that many lines such 
as this one had already been added after the release of 1.1.0, so I had to go 
through and remove many duplicates.  In the course of that process it seemed 
better for me to have some logical scheme to guide me in choosing which of the 
two duplicates to delete.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to