Github user culler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3066#discussion_r19733534
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala 
---
    @@ -187,7 +187,8 @@ case object NullType extends DataType
     
     object NativeType {
       val all = Seq(
    -    IntegerType, BooleanType, LongType, DoubleType, FloatType, ShortType, 
ByteType, StringType)
    +    IntegerType, BooleanType, LongType, DoubleType, FloatType, ShortType,
    +    ByteType, StringType, DateType, TimestampType)
    --- End diff --
    
    Yes, but the new line does exceed 100 columns due to the addition of two 
new items DateType and TimestampType.  (Or so the compiler tells me.)
    
    Perhaps there is a reason why these types should not be regarded as 
"Native" but I could not see any such reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to