Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2944#discussion_r19757342
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -361,6 +361,18 @@ class SparkContext(config: SparkConf) extends
SparkStatusAPI with Logging {
override protected def childValue(parent: Properties): Properties =
new Properties(parent)
}
+ /** Called by the web UI to obtain executor thread dumps */
+ private[spark] def getExecutorThreadDump(executorId: String):
Array[ThreadStackTrace] = {
+ if (executorId == SparkContext.DRIVER_IDENTIFIER) {
+ Utils.getThreadDump()
+ } else {
+ val (host, port) =
env.blockManager.master.getActorSystemHostPortForExecutor(executorId).get
--- End diff --
This is kind of scary; we might get `None.get` exceptions if the executor
dies while we try to get its stack trace. We should probably add a safeguard
for this case and log a warning or something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
