Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2944#discussion_r19769160
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1609,6 +1609,15 @@ private[spark] object Utils extends Logging {
s"$className: $desc\n$st"
}
+ /** Return a thread dump of all threads' stacktraces. Used to capture
dumps for the web UI */
+ def getThreadDump(): Array[ThreadStackTrace] = {
+ Thread.getAllStackTraces.toArray.sortBy(_._1.getId).map {
+ case (thread, stackElements) =>
+ val stackTrace = stackElements.map(_.toString).mkString("\n")
+ ThreadStackTrace(thread.getId, thread.getName,
thread.getState.toString, stackTrace)
--- End diff --
Just spotted a consistency issue here: `thread.getState` is grabbed at a
different time than the stack elements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
