Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21745#discussion_r201716700
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
 ---
    @@ -60,7 +60,8 @@ abstract class LogicalPlan
        * [[org.apache.spark.sql.catalyst.analysis.UnresolvedRelation 
UnresolvedRelation]]
        * should return `false`).
        */
    -  lazy val resolved: Boolean = expressions.forall(_.resolved) && 
childrenResolved
    +  lazy val resolved: Boolean = expressions.forall(_.resolved) && 
childrenResolved &&
    +    missingInput.isEmpty
    --- End diff --
    
    `missingInput` is special, mostly we can't resolve it. I think that's why 
we didn't consider it in the `resolved` at the first place.
    
    We can update the if condition in `ResolveMissingReferences` to take 
`missingInput` into consideration. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to