Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21745
Sorry replying via email.
The previously failed test case has a GROUPING with resolved references.
Since it's unresolved itself, the rule will go through underlying Project
and newExprs have resolved references coming from parents of this Project.
On Thu, Jul 12, 2018, 12:35 PM Wenchen Fan <[email protected]> wrote:
> *@cloud-fan* commented on this pull request.
> ------------------------------
>
> In
>
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
> <https://github.com/apache/spark/pull/21745#discussion_r201900877>:
>
> > @@ -1163,7 +1165,8 @@ class Analyzer(
> case p: Project =>
> val maybeResolvedExprs = exprs.map(resolveExpression(_, p))
> val (newExprs, newChild) =
resolveExprsAndAddMissingAttrs(maybeResolvedExprs, p.child)
> - val missingAttrs = AttributeSet(newExprs) --
AttributeSet(maybeResolvedExprs)
> + // The resolved attributes might not come from `p.child`.
Need to filter it.
>
> how can this happen? if the resolved attributes do not exist in child,
> then the plan is invalid, isn't it?
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/21745#pullrequestreview-136492814>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AAEM9343BTd9ldDog_ZVBhQ-oWsXltktks5uFsPmgaJpZM4VKwgt>
> .
>
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
