Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r202163335
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
// Set the coresponding index of Boolean var when the task killed by
other attempt tasks,
// this happened while we set the `spark.speculation` to true. The task
killed by others
// should not resubmit while executor lost.
- private val killedByOtherAttempt: Array[Boolean] = new
Array[Boolean](numTasks)
+ private val killedByOtherAttempt = new HashSet[Long]
--- End diff --
I think the hashset is fine, we shouldn't be keeping a huge array if we
don't need it. We use to much memory as it is. @jiangxb1987 how big of a deal
is this to you? I prefer the hashMap approach @mridulm mentions if that is the
useful information to you.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
