Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3073#discussion_r19787843
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
    @@ -88,10 +88,11 @@ case class FetchFailed(
     case class ExceptionFailure(
         className: String,
         description: String,
    -    stackTrace: Array[StackTraceElement],
    +    stackTrace: String,
    --- End diff --
    
    Since this is `@DeveloperApi` (and thus technically public), we can't 
change it in an incompatible way unless there's a really good reason, and it's 
even worse because it's a case class (so even providing a backwards-compatible 
constructor is insufficient). We could, however, do something of this form:
    
    ```scala
    case class ExeceptionFailure(
        className: String,
        description: String,
        stackTrace: Array[StackTraceElement],
        metrics: Option[TaskMetrics])
      extends TaskFailedReason {
    
      // Original behavior preserved for backwards compatibility.
      private var errorString = Utils.exceptionString(className, description, 
stackTrace)
    
      /** Overrides the stack trace message with a full (recursive) stack 
trace. */
      private[spark] def setFullStackTrace(fullStackTrace: String): this.type = 
{
        errorString = fullStackTrace
        this
      }
    
      override def toErrorString: String = errorString
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to